Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable static library installation by default #702

Merged
merged 4 commits into from
Apr 17, 2018
Merged

Disable static library installation by default #702

merged 4 commits into from
Apr 17, 2018

Conversation

Vascom
Copy link
Collaborator

@Vascom Vascom commented Mar 30, 2018

Static library not needed if shared library installed, isn't it?

@bluca
Copy link
Contributor

bluca commented Mar 30, 2018

One might have applications using either at the same time, distributions always ship both

@Vascom
Copy link
Collaborator Author

Vascom commented Mar 30, 2018

@bluca Are you shure? Why someone need use static and shared libs at the same time?
And about distributions you completely wrong
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries

Packages including libraries SHOULD exclude static libs as far as possible (eg by configuring with --disable-static). Applications linking against libraries SHOULD link against shared libraries not static versions.

@bluca
Copy link
Contributor

bluca commented Mar 30, 2018

I know that's the aspiration, in reality it's a bit different and users often ask for both - anyhow I don't care that much about the default, as long as there's an option for it

@Vascom
Copy link
Collaborator Author

Vascom commented Mar 30, 2018

Where option for it?

@xor-gate
Copy link
Member

Having a static library installed doesn't make any sense. Static library should only be used during static builds and distributed. We should stick with dynamic library for all systems except windows (mingw)/osx builds.

@Vascom
Copy link
Collaborator Author

Vascom commented Mar 30, 2018

Or may be you can add parameter to not build static lib at all?

@xor-gate
Copy link
Member

xor-gate commented Apr 1, 2018

Maybe about the static library build we should do something like the nanomsg project https://github.com/nanomsg/nanomsg/blob/master/CMakeLists.txt#L99

@Vascom
Copy link
Collaborator Author

Vascom commented Apr 2, 2018

It would be great.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@Vascom Vascom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@xor-gate xor-gate merged commit b1b2a2f into stlink-org:master Apr 17, 2018
@xor-gate
Copy link
Member

Thanks

@Vascom Vascom deleted the patch-2 branch April 17, 2018 08:33
@Nightwalker-87 Nightwalker-87 added this to the v1.5.1 milestone Feb 23, 2020
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants